Skip to content

Incorporate 3D fitting from Ahmed's masters project#217

Open
PaulHancock wants to merge 107 commits into
devfrom
AhmedHamadto-dev
Open

Incorporate 3D fitting from Ahmed's masters project#217
PaulHancock wants to merge 107 commits into
devfrom
AhmedHamadto-dev

Conversation

@PaulHancock
Copy link
Copy Markdown
Owner

@PaulHancock PaulHancock commented Dec 10, 2024 •
edited
Loading

This PR will add the functionality to address #40 (fitting across multiple images), by allowing Aegean to fit across multiple frequencies at once. Users will in put a cube with two spatial and one frequency dimension, and the sources that are returned will have been fit across all frequencies with a model that includes a spectral index.

These features are work in progress, and this PR will facilitate automated testing.

TODO:

  • Enable priorized fitting
  • Enable blind fitting
  • Figure out what to do about the data correlation across frequencies
  • Update BANE to work on / produce 3d bkg/rms maps
  • Allow users to have a psf that varies with frequency (define a data format)
  • Figure out what annotation files will look like

PaulHancock and others added 30 commits April 18, 2024 15:04
@PaulHancock
use mpi4py and write unique file names
dec65b6
@PaulHancock
add module to handle MPI checking
4a37007
@PaulHancock
use new mpi module
4a1d3ea
@PaulHancock
refactor mpi
e7bce01
@PaulHancock
set up barrier
1d0d1d6
@PaulHancock
update barrier
a79c295
@PaulHancock
debug message
152489b
@PaulHancock
update debug
3d463e3
@AhmedHamadto
collect all table names into a list and append the tables together.
7adecf7
@AhmedHamadto
Added a function addSuffix to append suffixes to file names before th…
279e77a 
…e extension
@AhmedHamadto
Added a new exception, and raise line in addSuffix function
6fa42dc
@AhmedHamadto
Created a fix for the first character being an underscore, updated ch…
7a586ef 
…angelog
@AhmedHamadto
added mpi4py to dependencies, added logger.info("MPI is available")
7601a58
@AhmedHamadto
Updated Changelog, added unit test for addSuffix, and corrected the a…
97a9715 
…ddSuffix function in Aegean
@AhmedHamadto
amended the if function at the end of the test file.
0e4c3d4
@AhmedHamadto
imported the function from aegean in the test file
20d99c1
@AhmedHamadto
removed the TODO comment as it has been addressed.
f9a06b2
@AhmedHamadto
Developer_Documentation
2cb4cba
@AhmedHamadto
Update python-test.yml
080d0aa
@AhmedHamadto
made mpi an optional dependency
848473a
@AhmedHamadto
Starting point
2e71bdf
@AhmedHamadto
Merge branch 'load_cube' of https://github.com/AhmedHamadto/Aegean-CIDS…
4d5a17e 
… into load_cube
@AhmedHamadto
Commented out optional dependency
0a25c60
@AhmedHamadto
Updated numpy version
9e65b89
@AhmedHamadto
added a description of the suffix error, updated the data load functi…
b5e3924 
…on, wrote tests for the data load function
@AhmedHamadto
Added the synthetic_with_alpha.fits file
0321fe0
@AhmedHamadto
Removed a comment
84543b8
@AhmedHamadto
Ported the work over to this branch
17edf70
@AhmedHamadto
Implementation and Unit Tests for the load_image_band function
d26da9f
@AhmedHamadto
added the .DS_Store to the git ignore
ae42f5f
@PaulHancock
Copy link
Copy Markdown
Owner Author

PaulHancock commented Dec 17, 2024

BANE now handles image cubes as intended:

  • 2d images produce 2d bkg/rms maps
  • 3d cube produce 3d bkg/rms maps unless you specify --slice=N in which case you'll get a 2d bkg/rms from the N'th freq band

Aegean is able to use this functionality to auto generate 3d bkg/rms images if they are not found.

@PaulHancock
Copy link
Copy Markdown
Owner Author

PaulHancock commented Feb 4, 2025

Pulled in changes that address #220 and deleted branch aeres-3d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@PaulHancock PaulHancock

@AhmedHamadto AhmedHamadto

Labels

None yet

Projects

None yet

Milestone

Aegean 3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@PaulHancock @AhmedHamadto